Fix incorrect #endif preprocessor comments in croutine.c and queue.c#1423
Merged
kstribrnAmzn merged 1 commit intoJun 12, 2026
Merged
Conversation
croutine.c: #if condition is ( configUSE_CO_ROUTINES != 0 ) but the #endif comment incorrectly said == 0, reversing the logic. queue.c: #if condition is ( configSUPPORT_DYNAMIC_ALLOCATION == 1 ) but the #endif comment incorrectly said configSUPPORT_STATIC_ALLOCATION, naming the wrong configuration option. These are purely cosmetic comment fixes with zero runtime impact. Signed-off-by: hanzhijian <hanzhijian@zepp.com>
Zepp-Hanzj
force-pushed
the
fix/endif-preprocessor-comments
branch
from
8827c05 to
a1f8a65
Compare
|
archigup
approved these changes
Jun 12, 2026
kstribrnAmzn
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two
#endifpreprocessor comments that don't match their corresponding#ifconditions:croutine.c:405 — The
#ifcondition is( configUSE_CO_ROUTINES != 0 )but the#endifcomment incorrectly says== 0, reversing the logic.queue.c:566 — The
#ifcondition is( configSUPPORT_DYNAMIC_ALLOCATION == 1 )but the#endifcomment incorrectly saysconfigSUPPORT_STATIC_ALLOCATION, naming the wrong configuration option.These are purely cosmetic comment fixes with zero runtime impact.
Test Steps
-Wall -Wextra.#if/#endifpairs in the diff.Checklist:
Related Issue
None
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.